fix: type prehydrate settings as AppSettings#1430
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe pull request updates the prehydrate utility to add a TypeScript type assertion when parsing settings from localStorage. The expression 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
2e4e166 to
5ea203f
Compare
5ea203f to
f19a7cc
Compare
|
Thanks for your first contribution, @ls-root! 🥳 We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role. |
This fixes an
anytype on the settings var that is getting read from thelocalStorage.I fixed this by parsing the settings object as the
AppSettingstype from/app/composables/useSettings.ts