fix: robust git-tarball fallback (statusCode + TAR errors)#481
Merged
Conversation
When a hosted git provider (e.g. GitLab) returns an HTML page with HTTP 200 for a private repo's archive endpoint instead of a proper 401/403, the tarball extraction fails with TAR_BAD_ARCHIVE. Previously, the fallback to git clone only triggered on HTTP errors. This widens the catch to include any TAR_* error code, allowing pacote to recover by cloning the repo directly. Fixes #476 Ref: npm/cli#3229
nishantms
approved these changes
May 1, 2026
Merged
This was referenced May 1, 2026
owlstronaut
pushed a commit
that referenced
this pull request
Jun 15, 2026
🤖 I have created a release *beep* *boop* --- ## [22.0.0](v21.5.0...v22.0.0) (2026-06-15) ###⚠️ BREAKING CHANGES * `pacote` now supports node `^22.22.2 || ^24.15.0 || >=26.0.0` * git specs using the `https` or `git+https` protocol now resolve to `git+https` URLs instead of being switched to `git+ssh`. Shortcut specs (e.g. `github:user/repo`, `user/repo`) and `git+ssh`/`git://` specs are unchanged. ### Features * [`09316f5`](09316f5) [#504](#504) bump to new node engine range (@owlstronaut) * [`2ab74b0`](2ab74b0) [#497](#497) strip patchedDependencies from the packed package.json (#497) (@manzoorwanijk) * [`66e7ea7`](66e7ea7) [#487](#487) forward globalIgnoreFile option to npm-packlist (@ljharb) ### Bug Fixes * [`ce804fb`](ce804fb) [#498](#498) avoid ReDoS in addGitSha committish stripping (#498) (@owlstronaut) * [`1f5f131`](1f5f131) [#494](#494) pass --global=false when preparing git dependencies (@owlstronaut) * [`e0af7f6`](e0af7f6) [#486](#486) respect ignoreScripts option for git dependencies (@owlstronaut) * [`12c8c8f`](12c8c8f) [#481](#481) fall back to git clone when tarball response is not a valid archive (@babyhuey) * [`61f065a`](61f065a) [#481](#481) use statusCode instead of constructor name for tarball fallback in git fetcher (@j1mb0-1) * [`6d160c1`](6d160c1) [#434](#434) do not switch to git+ssh for https repository links (#434) (@oldium) ### Dependencies * [`371e8b0`](371e8b0) [#504](#504) `ssri@14.0.0` * [`b68c6c2`](b68c6c2) [#504](#504) `sigstore@5.0.0` * [`57793ab`](57793ab) [#504](#504) `proc-log@7.0.0` * [`33eacc9`](33eacc9) [#504](#504) `npm-registry-fetch@20.0.1` * [`a131916`](a131916) [#504](#504) `npm-pick-manifest@12.0.0` * [`2b03527`](2b03527) [#504](#504) `npm-packlist@11.2.0` * [`5f8ad42`](5f8ad42) [#504](#504) `npm-package-arg@14.0.0` * [`ee3b96d`](ee3b96d) [#504](#504) `cacache@21.0.1` * [`033f655`](033f655) [#504](#504) `@npmcli/run-script@11.0.0` * [`ddcc738`](ddcc738) [#504](#504) `@npmcli/promise-spawn@10.0.0` * [`6a28eb2`](6a28eb2) [#504](#504) `@npmcli/package-json@8.0.0` * [`5879416`](5879416) [#504](#504) `@npmcli/installed-package-contents@5.0.0` * [`41ea727`](41ea727) [#504](#504) `@npmcli/git@8.0.0` ### Chores * [`3fc5fd4`](3fc5fd4) [#504](#504) `@npmcli/eslint-config@7.0.0` (@owlstronaut) * [`7350ab8`](7350ab8) [#504](#504) `hosted-git-info@10.1.1` (@owlstronaut) * [`c7c7d7f`](c7c7d7f) [#504](#504) template-oss-apply (@owlstronaut) * [`e9ac85e`](e9ac85e) [#501](#501) template-oss-apply (@owlstronaut) * [`e184356`](e184356) [#501](#501) `template-oss@5.1.0` (@owlstronaut) * [`644ebb6`](644ebb6) [#479](#479) template-oss-apply (@owlstronaut) * [`ee64bea`](ee64bea) [#479](#479) `@npmcli/template-oss@4.30.0` (@owlstronaut) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines #477 and #478 into a single fix for the git-tarball-to-clone fallback in
GitFetcher.Closes #476
Supersedes #477
Supersedes #478
Refs npm/cli#3229, npm/cli#2741, npm/cli#9186