wrap a timer around the rimraf call in npm-ci#2573
Merged
Conversation
isaacs
force-pushed
the
isaacs/ci-rm-timer
branch
from
62b11fc to
5895218
Compare
nlf
approved these changes
Jan 29, 2021
Contributor
nlf
left a comment
nlf
left a comment
There was a problem hiding this comment.
ah so because glob was traversing the whole tree we were taking forever? this totally makes sense
darcyclarke
added
Release 7.x
Fix: npm/arborist#207 PR-URL: #2573 Credit: @isaacs Close: #2573 Reviewed-by: @nlf
isaacs
force-pushed
the
isaacs/ci-rm-timer
branch
from
5895218 to
a8e77f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: npm/arborist#207
References