docs: fix build error from libvips + sharp#1555
Closed
christianbundy wants to merge 1 commit intonpm:latestfrom
Closed
docs: fix build error from libvips + sharp#1555christianbundy wants to merge 1 commit intonpm:latestfrom
christianbundy wants to merge 1 commit intonpm:latestfrom
Conversation
Problem: Sharp doesn't play nicely with a globally-installed version of libvips, and throws an error when you try to generate the documentation. with `npm run build:static`. This has been documented as an issue in the Gatsby issue tracker: gatsbyjs/gatsby#22303 Solution: Update the dependencies to pull in a new version of Sharp which is immune to this problem. I ran `npm update`, which is supposed to modify `package.json`, but it only changed `package-lock.json`. I removed `node_modules` and ran `npm install` and can confirm that his resolves the problem.
Contributor
|
Hi @christianbundy, thanks for taking the time to contribute ❤️ We appreciate it! Unfortunately with our focus switching to npm7, changes to the current npm6 release line are going to be limited to critical fixes for security issues and major bugs only. I'm really curious if this fix really applies to our docs since we haven't been noticing any problems in the output files or the build currently. Let me know if that's the case then we can follow up with it either in v6 or v7 depending on the severity of the possible problem. All the best and thanks again! 😄 |
This was referenced Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
Problem: Sharp doesn't play nicely with a globally-installed version of
libvips, and throws an error when you try to generate the documentation.
with
npm run build:static. This has been documented as an issue in theGatsby issue tracker: gatsbyjs/gatsby#22303
Solution: Update the dependencies to pull in a new version of Sharp
which is immune to this problem. I ran
npm update, which is supposedto modify
package.json, but it only changedpackage-lock.json. Iremoved
node_modulesand rannpm installand can confirm that hisresolves the problem.
References