Conversation
Got merged into one active directive during the Phase 2 extraction; the reference config kept this as a commented-out example, not a live filter. Doesn't explain the "no logs in production" report -- verified if=\$loggable still logs non-444 responses fine -- but it's a real deviation from the source, worth fixing regardless. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
access_log ... if=$loggable;inops/nginx/server-block.conf, which got accidentally merged into one active directive during the Phase 2 extraction in #874. The reference config keptif=$loggableas a commented-out example, not a live filter - restored that.Found while investigating a "no logs in production" report after the production deploy. Turned out not to be the cause (verified
if=$loggablestill logs non-444 responses fine) - the real cause is thatdigitalcollections.lib.utk.eduandhykuadmin.lib.utk.eduare served by manually-created Ingress resources (utk-digitalcollections,utk-hykuadmin) that still point directly atutk-hyku-production-hyrax, bypassing the new nginx pod entirely. That's a live ingress patch, not a code change, so it's not part of this PR - flagging here for visibility.Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com