Repository navigation
feat(push): audience count and device delete - #74
Merged
Merged
Conversation
Two hub routes the module did not call, on the sync and the async client:
POST /notifications/push/campaigns/audience-count
(get_push_campaign_audience_count — how many devices an audience would reach,
nothing is sent) and DELETE /notifications/push/devices/{Id}
(delete_push_device — remove one device from whichever user holds it, an
admin route; the gateway spells this token `{Id}`, the read `{id}`).
The push route table asserts the verb and the resolved path of both (40 routes
now) and compares the path with urlparse, as the SMS and Email tables do,
instead of endswith. docs/hub/push.md shows both.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push campaign audience count and device delete methods (sync + async), route-asserting tests, docs rows.
Tests: make check (ruff, typecheck, pytest) green, 1270 passed.
Task file: gateway docs/tasks/messaging-coverage-2026-11-03.md (branch audit/messaging). Expected: minor release.