Skip to content

mobile outbox never matches V2 dispatch error tags #38

Description

@nohat

Found during the V2 catch-up (#36), not fixed there.

apps/mobile/src/state/thread-outbox-model.ts (shouldRetryThreadOutboxDelivery, around lines 267-283 on sync/upstream-20261005) switches on the V1 tag OrchestrationDispatchCommandError, which V2 servers no longer throw. V2 failures (OrchestrationV2DispatchCommandError, OrchestrationV2ThreadLaunchError) fall through to message-text sniffing, so whether a server-decided refusal restores the draft or is retried as a transport failure depends on its wording (isTransportConnectionErrorMessage). The drain hold was ported to match both V2 tags with reason: "server-draining" (4dd0f74); every other V2 refusal is still unmatched. Upstream has the same code.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions