test(fetch): settle h2 internal stream errors

test/fetch/http2-stream-internal-error.js

@@ -0,0 +1,68 @@
+'use strict'
+
+const assert = require('node:assert')
+const { createServer, createSecureServer, constants } = require('node:http2')
+const { once } = require('node:events')
+const { test } = require('node:test')
+
+const pem = require('@metcoder95/https-pem')
+
+const { Agent, Client, fetch } = require('../..')
+
+const { closeClientAndServerAsPromise } = require('../utils/node-http')
+
+test('fetch rejects when an HTTP/2 stream is reset with NGHTTP2_INTERNAL_ERROR', { timeout: 5000 }, async (t) => {
+  const server = createServer()
+  server.on('stream', (stream) => {
+    stream.on('error', () => {})
+    stream.close(constants.NGHTTP2_INTERNAL_ERROR)
+  })
+
+  server.listen(0)
+  await once(server, 'listening')
+
+  const dispatcher = new Agent({ useH2c: true })
+  t.after(async () => {
+    await dispatcher.destroy()
+    await new Promise((resolve, reject) => server.close((err) => err ? reject(err) : resolve()))
+  })
+
+  await assert.rejects(
+    fetch(`http://localhost:${server.address().port}/`, { dispatcher }),
+    (err) => {
+      assert.strictEqual(err.name, 'TypeError')
+      assert.strictEqual(err.cause?.code, 'ERR_HTTP2_STREAM_ERROR')
+      assert.strictEqual(err.cause?.http2ErrorCode, constants.NGHTTP2_INTERNAL_ERROR)
+      return true
+    }
+  )
+})
+
+test('fetch rejects when a TLS HTTP/2 stream is reset with NGHTTP2_INTERNAL_ERROR', { timeout: 5000 }, async (t) => {
+  const server = createSecureServer(await pem.generate({ opts: { keySize: 2048 } }))
+  server.on('stream', (stream) => {
+    stream.on('error', () => {})
+    stream.close(constants.NGHTTP2_INTERNAL_ERROR)
+  })
+
+  server.listen(0)
+  await once(server, 'listening')
+
+  const client = new Client(`https://localhost:${server.address().port}`, {
+    connect: {
+      rejectUnauthorized: false
+    },
+    allowH2: true
+  })
+  t.after(closeClientAndServerAsPromise(client, server))
+
+  await assert.rejects(
+    fetch(`https://localhost:${server.address().port}/`, { dispatcher: client }),
+    (err) => {
+      assert.strictEqual(err.name, 'TypeError')
+      assert.strictEqual(err.cause?.code, 'ERR_HTTP2_STREAM_ERROR')
+      assert.strictEqual(err.cause?.http2ErrorCode, constants.NGHTTP2_INTERNAL_ERROR)
+      return true
+    }
+  )
+})

test/http2-request-never-settles.js

@@ -97,9 +97,15 @@ async function churningServer (rnd) {
         case 'goaway-refuse':
           stream.session.goaway(constants.NGHTTP2_NO_ERROR, 0)
           break
-        case 'kill-session':
-          stream.session.destroy()
+        case 'kill-session': {
+          // nodejs/node#64850 / #64841: destroy() inside this handler runs
+          // during nghttp2 mem_recv and aborts the process.
+          const session = stream.session
+          setImmediate(() => {
+            try { session.destroy() } catch {}
+          })
           break
+        }
         case 'no-answer':
           break
       }