fix: avoid unbounded recursion in Set-Cookie attribute parser - #5757
Merged
Conversation
parseUnparsedAttributes recursed once per Set-Cookie attribute with no depth bound, so a response header of the form 'a=b;;;;...' overflowed the stack and threw an uncaught RangeError. Convert the algorithm to an iterative loop, threading cookieAttributeList through each iteration as before.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5757 +/- ##
=======================================
Coverage 93.46% 93.46%
=======================================
Files 110 110
Lines 38939 38940 +1
=======================================
+ Hits 36394 36397 +3
+ Misses 2545 2543 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Sep 2, 2026
Merged
|
Hello, could this fix perhaps be back-ported to v6 / v7 as well please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
parseUnparsedAttributesinlib/web/cookies/parse.jsrecursed once perSet-Cookieattribute with no depth bound. A single response header of the forma=b;;;;...overflowed the stack and threw an uncaughtRangeErrorout ofgetSetCookies.This converts the algorithm to an iterative loop, threading
cookieAttributeListthrough each iteration exactly as the recursion did. No behavior change; the parser no longer grows the stack per attribute.Verification
'a=b' + ';'.repeat(5000)now parses successfully instead of throwingRangeError: Maximum call stack size exceeded.test/cookie/cookies.js.