fix(eventsource): validate Last-Event-ID on reconnect - #5746
Merged
Conversation
Encode last event IDs as UTF-8 before placing them in the internal header list. Clear stale values and omit IDs that cannot be transported as HTTP header values. Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5746 +/- ##
=======================================
Coverage 93.46% 93.47%
=======================================
Files 110 110
Lines 38934 38946 +12
=======================================
+ Hits 36389 36403 +14
+ Misses 2545 2543 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Sep 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UTF-8 encode EventSource last event IDs before adding them to the internal request header list. Clear stale values and omit IDs that cannot be transported as HTTP header values, preventing repeated local reconnect failures while preserving valid Unicode IDs.
Refs: GHSA-q9qx-47rg-rhc7