Skip to content

fix(eventsource): validate Last-Event-ID on reconnect - #5746

Merged
mcollina merged 1 commit into
mainfrom
fix/eventsource-last-event-id
Sep 2, 2026
Merged

fix(eventsource): validate Last-Event-ID on reconnect#5746
mcollina merged 1 commit into
mainfrom
fix/eventsource-last-event-id

Conversation

@mcollina

Copy link
Copy Markdown
Member

UTF-8 encode EventSource last event IDs before adding them to the internal request header list. Clear stale values and omit IDs that cannot be transported as HTTP header values, preventing repeated local reconnect failures while preserving valid Unicode IDs.

Refs: GHSA-q9qx-47rg-rhc7

Encode last event IDs as UTF-8 before placing them in the internal header list. Clear stale values and omit IDs that cannot be transported as HTTP header values.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@codecov-commenter

codecov-commenter commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.47%. Comparing base (c32ea13) to head (195facc).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5746   +/-   ##
=======================================
  Coverage   93.46%   93.47%           
=======================================
  Files         110      110           
  Lines       38934    38946   +12     
=======================================
+ Hits        36389    36403   +14     
+ Misses       2545     2543    -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina
mcollina merged commit 32ea0ea into main Sep 2, 2026
38 checks passed
@mcollina
mcollina deleted the fix/eventsource-last-event-id branch September 2, 2026 12:41
@github-actions github-actions Bot mentioned this pull request Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants