Skip to content

fix: propagate dispatcher options to base class - #5687

Merged
mcollina merged 1 commit into
mainfrom
fix/dispatcher-websocket-options
Aug 21, 2026
Merged

fix: propagate dispatcher options to base class#5687
mcollina merged 1 commit into
mainfrom
fix/dispatcher-websocket-options

Conversation

@mcollina

Copy link
Copy Markdown
Member

Pass dispatcher options to DispatcherBase in proxy and pool wrappers so their configured WebSocket limits are exposed to the WebSocket parser instead of being replaced by the defaults.

Add regression coverage for BalancedPool, RoundRobinPool, ProxyAgent, EnvHttpProxyAgent, and Socks5ProxyAgent.

@codecov-commenter

codecov-commenter commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.46%. Comparing base (76b2b0a) to head (dedc9cd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5687      +/-   ##
==========================================
- Coverage   93.46%   93.46%   -0.01%     
==========================================
  Files         110      110              
  Lines       38899    38899              
==========================================
- Hits        36358    36356       -2     
- Misses       2541     2543       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
mcollina force-pushed the fix/dispatcher-websocket-options branch from a145c3e to dedc9cd Compare August 21, 2026 19:21
@mcollina
mcollina merged commit 7eb7c8e into main Aug 21, 2026
38 checks passed
@mcollina
mcollina deleted the fix/dispatcher-websocket-options branch August 21, 2026 19:53
@github-actions github-actions Bot mentioned this pull request Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants