Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/dispatcher/client-h2.js
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,7 @@ function writeH2 (client, request) {
++session[kOpenStreams]
completeRequest(client, request)
})
stream.on('error', abort)
stream.once('close', () => {
session[kOpenStreams] -= 1
if (session[kOpenStreams] === 0) session.unref()
Expand Down
65 changes: 65 additions & 0 deletions test/issue-5638.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
'use strict'

const { test } = require('node:test')
const assert = require('node:assert')
const net = require('node:net')
const { H2CClient } = require('..')

const frame = (type, flags, streamId, payload = Buffer.alloc(0)) => {
const head = Buffer.alloc(9)
head.writeUIntBE(payload.length, 0, 3)
head[3] = type
head[4] = flags
head.writeUInt32BE(streamId, 5)
return Buffer.concat([head, payload])
}

const SETTINGS = frame(0x4, 0x0, 0)
const SETTINGS_ACK = frame(0x4, 0x1, 0)
const GOAWAY = frame(0x7, 0x0, 0, Buffer.alloc(8))

test('#5638 - h2 CONNECT settles after GOAWAY(lastStreamID=0)', { timeout: 5000 }, async (t) => {
const server = net.createServer((socket) => {
let buf = Buffer.alloc(0)
let preface = false
let sent = false

socket.on('error', () => {})
socket.write(SETTINGS)

socket.on('data', (chunk) => {
buf = Buffer.concat([buf, chunk])
if (!preface) {
if (buf.length < 24) return
buf = buf.subarray(24)
preface = true
}

while (buf.length >= 9) {
const length = buf.readUIntBE(0, 3)
const type = buf[3]
const flags = buf[4]
if (buf.length < 9 + length) break
buf = buf.subarray(9 + length)

if (type === 0x4 && !(flags & 0x1)) socket.write(SETTINGS_ACK)
if (type === 0x1 && !sent) {
sent = true
socket.write(GOAWAY)
setTimeout(() => socket.end(), 50)
}
}
})
})

await new Promise((resolve) => server.listen(0, '127.0.0.1', resolve))
t.after(() => server.close())

const client = new H2CClient(`http://127.0.0.1:${server.address().port}`)
t.after(() => client.close())

await assert.rejects(client.connect({ path: '/' }), {
code: 'UND_ERR_SOCKET',
message: 'HTTP/2: "GOAWAY" frame received with code 0'
})
})
Loading