fix(h1): ignore type of service errors#5547
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5547 +/- ##
==========================================
- Coverage 93.45% 93.44% -0.01%
==========================================
Files 110 110
Lines 37376 37443 +67
==========================================
+ Hits 34928 34987 +59
- Misses 2448 2456 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ronag
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Fixes #5544.
Rationale
socket.setTypeOfService()is best-effort QoS marking. It can throw synchronously on some platforms depending on socket state, and the default request path should not touch it when no ToS value was explicitly requested.Changes
Features
N/A
Bug Fixes
setTypeOfService(0)for fresh HTTP/1.1 sockets whentypeOfServicewas not explicitly provided.0after an explicitly prioritized request.setTypeOfService()failures so they do not abort requests or crash the process.setTypeOfService()errors.Breaking Changes and Deprecations
N/A
Status
Tested with:
npx borp -p "test/ip-prioritization.js"npm run lint