Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/web/fetch/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -1439,7 +1439,7 @@ function hasAuthenticationEntry (request) {
*/
function includesCredentials (url) {
// A URL includes credentials if its username or password is not the empty string.
return !!(url.username && url.password)
return !!(url.username || url.password)
}

/**
Expand Down
24 changes: 24 additions & 0 deletions test/fetch/includes-credentials.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
'use strict'

const { test } = require('node:test')
const { includesCredentials } = require('../../lib/web/fetch/util')

test('includesCredentials returns true for URL with both username and password', () => {
const url = new URL('http://user:pass@example.com')
require('node:assert').strictEqual(includesCredentials(url), true)
})

test('includesCredentials returns true for URL with only username', () => {
const url = new URL('http://user@example.com')
require('node:assert').strictEqual(includesCredentials(url), true)
})

test('includesCredentials returns true for URL with only password', () => {
const url = new URL('http://:pass@example.com')
require('node:assert').strictEqual(includesCredentials(url), true)
})

test('includesCredentials returns false for URL with no credentials', () => {
const url = new URL('http://example.com')
require('node:assert').strictEqual(includesCredentials(url), false)
})
Loading