-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: create release schedule component #8529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website @nodejs/web-infra Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8529 +/- ##
==========================================
+ Coverage 74.70% 74.98% +0.27%
==========================================
Files 102 103 +1
Lines 8956 9042 +86
Branches 305 312 +7
==========================================
+ Hits 6691 6780 +89
+ Misses 2263 2260 -3
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR replaces the static SVG image of the Node.js release schedule with a dynamically generated component that fetches schedule data from GitHub and renders it using the lts library.
Key Changes:
- Adds a new
ReleaseScheduleReact component that dynamically generates the schedule visualization - Introduces a data provider to fetch release schedule JSON from the Node.js Release repository
- Replaces the static image reference in the MDX file with the new component
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Adds lts package from GitHub repository along with its dependencies (d3, jsdom, svg2png, etc.) |
| apps/site/package.json | Declares the lts dependency from GitHub repository |
| apps/site/next.constants.mjs | Adds RELEASE_SCHEDULE_URL constant pointing to schedule.json |
| apps/site/next-data/generators/releaseSchedule.mjs | Creates fetch function for release schedule data |
| apps/site/next-data/providers/releaseSchedule.ts | Provides cached access to release schedule data |
| apps/site/components/Releases/ReleaseSchedule/index.tsx | Implements the ReleaseSchedule component with SVG generation |
| apps/site/mdx/components.mjs | Registers ReleaseSchedule component for MDX usage |
| apps/site/pages/en/about/previous-releases.mdx | Replaces static image with ReleaseSchedule component |
| apps/site/next-env.d.ts | Updates TypeScript reference path (appears unintentional) |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Build Size ComparisonSummary
Changes➕ Added Assets (2)
➖ Removed Assets (2)
|
|
(I'll fix the comparator to comment on fork PRs) |
|
@araujogui do we have a path forward? |
I'm waiting for the upstream to get merged. |
Description
Create new release schedule component
Validation
Related Issues
Fixes #8101
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.