benchmark: pass execArgv to the benchmarking process#928
Closed
petkaantonov wants to merge 1 commit intonodejs:v1.xfrom
Closed
benchmark: pass execArgv to the benchmarking process#928petkaantonov wants to merge 1 commit intonodejs:v1.xfrom
petkaantonov wants to merge 1 commit intonodejs:v1.xfrom
Conversation
Benchmarker should pass exec flags (e.g. --no-crankshaft, --turbofan-filter, --trace-opt etc) to the benchmarking process
Contributor
Contributor
|
Feel free to merge now, I think this should be a relatively innocuous change. |
Contributor
|
👍 |
sam-github
pushed a commit
to sam-github/node
that referenced
this pull request
Feb 25, 2015
Benchmarker should pass exec flags (e.g. --no-crankshaft, --turbofan-filter, --trace-opt etc) to the benchmarking process Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> PR-URL: nodejs#928
Contributor
|
Landed in 8a1e22a, thank you. |
petkaantonov
added a commit
to petkaantonov/io.js
that referenced
this pull request
Feb 25, 2015
Benchmarker should pass exec flags (e.g. --no-crankshaft, --turbofan-filter, --trace-opt etc) to the benchmarking process Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> PR-URL: nodejs#928
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmarker should pass exec flags (e.g. --no-crankshaft,
--turbofan-filter, --trace-opt etc) to the benchmarking process