lib: update outdated comment#8968
lib: update outdated comment#8968tanujasawant wants to merge 1 commit intonodejs:masterfrom tanujasawant:master
Conversation
nodejs-github-bot
added
the
child_process
tanujasawant
changed the title
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM.
Thank you @Tanuja-Sawant!
This change is small enough that it should not need to wait the full 48 hours to land.
|
One nit: @Tanuja-Sawant, can you please update the commit log message to follow the guidelines described in the contributor's guide? |
|
@jasnell is this commit log fine? |
|
@Tanuja-Sawant ... my apologies for not being clear. I meant the actual commit log message here: e5ed61f. You can update it using |
| if (!Array.isArray(options.stdio)) { | ||
| // Leave stdin open for the IPC channel. stdout and stderr should be the | ||
| // same as the parent's if silent isn't set. | ||
| // Use a separate fd=4 for IPC channel. Inherit stdin, stdout and stderr |
There was a problem hiding this comment.
I think the correct fd index for the IPC channel here should be fd=3, not fd=4.
Quoting the docs:
The fds 0, 1, and 2 correspond to stdin, stdout, and stderr, respectively.
| if (!Array.isArray(options.stdio)) { | ||
| // Leave stdin open for the IPC channel. stdout and stderr should be the | ||
| // same as the parent's if silent isn't set. | ||
| // Use a separate fd=4 for IPC channel. Inherit stdin, stdout and stderr |
There was a problem hiding this comment.
Please leave the "the" before "IPC channel". Also, please add a comma after "stdout."
|
Hi! |
6 participants
Checklist
Affected core subsystem(s)
just comments
Description of change
Updated an outdated comment in child_process.js to describe the code better.