test: mark test-tick-processor-unknown flaky#8900
test: mark test-tick-processor-unknown flaky#8900Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
|
CI is yellow, with the only cause of yellow being the test marked flaky by this PR. So: Woot. |
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM. Is the test flaky on all platforms or is it mostly windows+smartos?
Mostly those two that I've noticed. |
|
Quick stress test (just 100 runs) across all (or all-ish) platforms to see if it's really flaky nearly everywhere or if it's really just SmartOS and Windows: https://ci.nodejs.org/job/node-stress-single-test/971/ |
|
Based on the stress test results, I'll change this to just marking it as flaky on SmartOS. |
Mark test-tick-processor-unknown flaky on SmartOS.
|
Argh, here it is failing on Raspberry Pi: https://ci.nodejs.org/job/node-test-binary-arm/4145/RUN_SUBSET=4,label=pi2-raspbian-wheezy/console Hoping that might be fixed by #8848 so might leave it as is. SmartOS seems to be The Big One that this test fails a lot on so getting just that in will still be a big win. |
Mark test-tick-processor-unknown flaky on SmartOS. PR-URL: nodejs#8900 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
|
Landed in d097311 |
Mark test-tick-processor-unknown flaky on SmartOS. PR-URL: #8900 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Mark test-tick-processor-unknown flaky on SmartOS. PR-URL: #8900 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Conflicts: test/parallel/parallel.status
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change