test: favor === over in == in http test#8471
Conversation
|
LGTM, thank you! :) By the way, your author name in this commit is given as “jun-oka”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you. |
|
LGTM |
|
@addaleax Thank you for that info! In that case, I prefer to use "Junshu Okamoto". |
|
@jun-oka I guess @Trott is around somewhere and can help you, but usually, you can update the commit here yourself. It goes something like this: git config --global user.name 'Junshu Okamoto' # (leave out the --global if you only want this for Node)
git commit --amend --reset-author
git push --force-with-lease(git magic! 😄) |
test/parallel/test-http.js
Outdated
There was a problem hiding this comment.
Can you update assert.equal() here and elsewhere to use assert.strictEqual() instead? Might as well get all our minor refactoring in at once. :-D
jun-oka
force-pushed
the
test-http-eqeqeq
branch
from
bacf52e to
42a2e81
Compare
|
LGTM if CI doesn't reveal any surprises. |
|
It seems unrelated error, I hope. |
|
The |
test/parallel/test-http.js
Outdated
There was a problem hiding this comment.
Now that you are doing this, why don't you change the requires as well.
There was a problem hiding this comment.
@thefourtheye That's right. Let me do that.
|
LGTM |
jun-oka
force-pushed
the
test-http-eqeqeq
branch
from
21f2b7d to
b05c4e8
Compare
|
I updated :) |
|
Hmm error again. |
|
Errors in CI are unrelated build issues and one known flaky. |
* favor ’===’ over in ’==’ * favor ’assert.strictEqual’ over ’assert.equal’ * favor ’const’ over ’var’ PR-URL: nodejs#8471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 7f2c9ba |
|
Thank you Trott |
* favor ’===’ over in ’==’ * favor ’assert.strictEqual’ over ’assert.equal’ * favor ’const’ over ’var’ PR-URL: #8471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* favor ’===’ over in ’==’ * favor ’assert.strictEqual’ over ’assert.equal’ * favor ’const’ over ’var’ PR-URL: #8471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* favor ’===’ over in ’==’ * favor ’assert.strictEqual’ over ’assert.equal’ * favor ’const’ over ’var’ PR-URL: #8471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* favor ’===’ over in ’==’ * favor ’assert.strictEqual’ over ’assert.equal’ * favor ’const’ over ’var’ PR-URL: #8471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* favor ’===’ over in ’==’ * favor ’assert.strictEqual’ over ’assert.equal’ * favor ’const’ over ’var’ PR-URL: #8471 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
9 participants
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test http
Description of change