Skip to content

doc: list futimes among fd APIs disabled by the permission model - #66649

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:list-futimes-among-fd-apis-disabled-by-the-permiss
Oct 13, 2026
Merged

doc: list futimes among fd APIs disabled by the permission model#66649
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:list-futimes-among-fd-apis-disabled-by-the-permiss

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Oct 10, 2026

Copy link
Copy Markdown
Member

doc: list futimes among fd APIs disabled by the permission model

@RafaelGSS
doc: list futimes among fd APIs disabled by the permission model
81c0b91 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. permission Issues and PRs related to the Permission Model. labels Oct 10, 2026
@RafaelGSS RafaelGSS added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 12, 2026
@nodejs-github-bot nodejs-github-bot added the lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. label Oct 12, 2026
aduh95
aduh95 approved these changes Oct 13, 2026
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been easier to review if you had shown the code i.e.

node/lib/fs.js

Lines 2772 to 2775 in c883ccf

if (permission.isEnabled()) {
callback(new ERR_ACCESS_DENIED('futimes API is disabled when Permission Model is enabled.'));
return;
}

node/lib/internal/fs/promises.js

Lines 2074 to 2077 in c883ccf

async function futimes(handle, atime, mtime) {
if (permission.isEnabled()) {
throw new ERR_ACCESS_DENIED('futimes API is disabled when Permission Model is enabled.');
}

@nodejs-github-bot
nodejs-github-bot merged commit 280ea27 into nodejs:main Oct 13, 2026
37 checks passed
@nodejs-github-bot

nodejs-github-bot commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator

Landed in 280ea27

@nodejs-github-bot nodejs-github-bot removed commit-queue PRs queued for automated landing through the Commit Queue. lacks-second-approval Commit Queue PRs awaiting a second collaborator approval or completion of the required wait. labels Oct 13, 2026
richardlau pushed a commit that referenced this pull request Oct 13, 2026
@RafaelGSS @richardlau
doc: list futimes among fd APIs disabled by the permission model
5c602a5 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #66649
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@richardlau richardlau mentioned this pull request Oct 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@efekrskl efekrskl efekrskl approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. permission Issues and PRs related to the Permission Model.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RafaelGSS @nodejs-github-bot @lpinca @efekrskl @aduh95