Skip to content

[v26.x backport] BoringSSL support#63433

Closed
aduh95 wants to merge 3 commits into
nodejs:v26.x-stagingfrom
panva:backport-63161-to-26
Closed

[v26.x backport] BoringSSL support#63433
aduh95 wants to merge 3 commits into
nodejs:v26.x-stagingfrom
panva:backport-63161-to-26

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented May 19, 2026

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch. labels May 19, 2026
panva added 3 commits May 19, 2026 17:44
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#63161
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
BoringSSL declares EVP_CIPHER_do_all_sorted and
EVP_MD_do_all_sorted, but stock no-decrepit builds do not provide
those symbols. Add a Node build flag that keeps ncrypto and its
dependents on a local BoringSSL fallback list when libdecrepit is
absent.

Keep embedders that provide the EVP enumeration symbols on the normal
OpenSSL-compatible path, matching Electron's patched BoringSSL build.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#63206
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#63206
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panva panva force-pushed the backport-63161-to-26 branch from 890215f to f58a33a Compare May 19, 2026 15:44
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented May 19, 2026

LGTM

aduh95 pushed a commit that referenced this pull request May 19, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63161
Backport-PR-URL: #63433
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request May 19, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #63206
Backport-PR-URL: #63433
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented May 19, 2026

Landed in b871cff...f14ed76

@aduh95 aduh95 closed this May 19, 2026
@panva panva deleted the backport-63161-to-26 branch May 19, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v26.x Issues that can be reproduced on v26.x or PRs targeting the v26.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants