Skip to content

Conversation

@sxa
Copy link
Member

@sxa sxa commented Jan 28, 2026

This reverts commit 7698480.

Failure was only seen on one machine where an underlying problem has been resolved. This no longer needs to be marked as flaky.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Jan 28, 2026
@nodejs-github-bot
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.78%. Comparing base (37e4004) to head (5f1be79).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #61560   +/-   ##
=======================================
  Coverage   89.78%   89.78%           
=======================================
  Files         673      673           
  Lines      203775   203775           
  Branches    39166    39167    +1     
=======================================
+ Hits       182956   182959    +3     
- Misses      13139    13152   +13     
+ Partials     7680     7664   -16     

see 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

@sxa
Copy link
Member Author

sxa commented Jan 28, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71100/

Resuming due to smartos test failure:

12:46:56 Failed tests:
12:46:56 out/Release/node /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos22-x64/test/parallel/test-child-process-fork-closed-channel-segfault.js

@sxa sxa added v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

Status: Need Triage

Development

Successfully merging this pull request may close these issues.

5 participants