Skip to content

Conversation

@kimtaejin3
Copy link
Contributor

This PR avoids potential prototype pollution and improves performance by replacing method calls with
direct property access.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Jan 24, 2026
@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.78%. Comparing base (5d39030) to head (d6f31dc).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61500      +/-   ##
==========================================
- Coverage   89.82%   89.78%   -0.04%     
==========================================
  Files         667      672       +5     
  Lines      203693   203907     +214     
  Branches    39163    39199      +36     
==========================================
+ Hits       182963   183078     +115     
- Misses      13061    13162     +101     
+ Partials     7669     7667       -2     
Files with missing lines Coverage Δ
lib/internal/socketaddress.js 98.98% <100.00%> (ø)

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kimtaejin3 kimtaejin3 changed the title lib: use bracket notation instead of startsWith/endsWith for single char lib: use bracket notation instead of startsWith/endsWith for single char Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants