Skip to content

url: fix constructor error message for URLPattern #57482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Mar 17, 2025
Merged

url: fix constructor error message for URLPattern #57482

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ecc9db
url: fix constructor error message for URLPattern
jakecastelli Mar 15, 2025
79acb79
remove test for error message
jakecastelli Mar 16, 2025
2352bef
Update test/parallel/test-urlpattern.js
jakecastelli Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/node_url_pattern.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ void URLPattern::New(const FunctionCallbackInfo<Value>& args) {
options.has_value() ? &options.value() : nullptr);

if (!url_pattern) {
THROW_ERR_INVALID_URL_PATTERN(env, "Failed to constuct URLPattern");
THROW_ERR_INVALID_URL_PATTERN(env, "Failed to construct URLPattern");
return;
}

Expand Down
4 changes: 4 additions & 0 deletions test/parallel/test-urlpattern.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,7 @@ throws(() => {
}, {
message: 'boom'
});

throws(() => {
new URLPattern('invalid value');
}, /TypeError: Failed to construct URLPattern/);
Loading