collaborator_guide: clarify commit message rules#5661
Closed
geek wants to merge 3 commits intonodejs:masterfrom
Closed
collaborator_guide: clarify commit message rules#5661geek wants to merge 3 commits intonodejs:masterfrom
geek wants to merge 3 commits intonodejs:masterfrom
Conversation
Italicize the full URL being required in metadata
geek
referenced
this pull request
Mar 11, 2016
The properties on memoryUsage were not checked before, this commit checks them. PR-URL: #5546 Reviewed-By: Colin Ihrig <[email protected]>
COLLABORATOR_GUIDE.md
Outdated
| pull request being merged so it's easy to trace a commit back to the | ||
| conversation that led up to that change. | ||
| - A `Fixes: X` line, where _X_ is either includes the full GitHub URL | ||
| - A `Fixes: X` line, where _X_ is either includes the *full* GitHub URL |
Member
There was a problem hiding this comment.
While you're in here, might as well fix the is either includes business, yeah?
Member
|
LGTM with one comment. |
Member
|
LGTM with the same nit ;) |
geek
added a commit
that referenced
this pull request
Mar 13, 2016
Italicize the full URL being required in metadata. PR-URL: #5661 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James Snell <[email protected]>
Member
Author
|
Landed in 4c4d9ae |
evanlucas
pushed a commit
that referenced
this pull request
Mar 14, 2016
Italicize the full URL being required in metadata. PR-URL: #5661 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James Snell <[email protected]>
Merged
rvagg
pushed a commit
that referenced
this pull request
Mar 16, 2016
Italicize the full URL being required in metadata. PR-URL: #5661 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
Italicize the full URL being required in metadata. PR-URL: #5661 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Italicize the full URL being required in metadata. PR-URL: #5661 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Italicize the full URL being required in metadata. PR-URL: #5661 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
None, just the contributing_guide
Description of change
Italicize the full URL being required in metadata. I have added commits to core that lacked the full URL, as have others in the past. I want to make it more obvious for future contributors.