deps: upgrade npm in LTS to 2.14.21 for Node.js 0.10 Maintenance#5593
deps: upgrade npm in LTS to 2.14.21 for Node.js 0.10 Maintenance#5593othiym23 wants to merge 1 commit intonodejs:v0.10-stagingfrom
Conversation
|
Nice, thanks @othiym23! @thealphanerd what are the chances of getting citgm going here? |
|
Also, |
|
citgm: https://ci.nodejs.org/job/thealphanerd-smoker/106/ I have no idea if this is going to work on v0.10.x Fingers crossed 😄 edit: gotta change some flags for v0.10 Will get it up soon |
|
Here's another attempt at citgm: https://ci.nodejs.org/job/thealphanerd-smoker-no-intl/5/ This should work. Found some sever major changes between 0.10 and above that were broken in citgm... this should fix it |
|
One more time: https://ci.nodejs.org/job/thealphanerd-smoker-no-intl/6/ edit: the moment failures we are seeing in moment are being tracked upstream moment/moment#3016 |
|
WRT the moment.js error, it's DST related, and should go away on its own by this Monday. We have a fix pending in a PR, but see no need to push a hotfix release for such a minor issue at this time. |
|
Could this be closed now? |
|
we have a newer version of npm in v0.10 now. Closing |
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
depsDescription of change
Upgrades the v0.10 maintenance branch to use
npm@lts/npm@2.Testing this is going to require something like citgm, because 0.10 has the old, broken
test-npmstanza in the Makefile. I can tell you that this build has passed running with Node 0.10 in Travis.I tried to be conservative about what tags I applied, and apologize in advance if I misinterpreted the meanings of the ones that I set. This might also need
lts-agenda, since I understand this will be discussed at this week's LTS meeting.r: @thealphanerd
r: @Fishrock123