Conversation
|
I have no opinion on whether this is a good or a bad change, I just want to point out that it makes automatic merging from joyent/node pretty much impossible. Not the end of the world, just something to keep in mind. |
|
Considering it only took 10 minutes or so, I'm not worried if this gets dropped for now. Any suggestions on a cleaner way to do it? |
Previously the order made no sense, especially since `toc.markdown` was alphabetized but `all.markdown` was not. This might fix issue nodejs#393 but after PR nodejs#553, I don't think we're on the same page.
|
Maybe this should be pulled against joynet/node first? |
|
I'm happy to make up a new pull request there as long as there is interest in the reordering. |
|
You might want to bring up the issue there. It would be easier to migrate up, i think. |
|
Sounds good. I'll open an issue similar to #393 and check the feedback. |
|
Closing this until we see how things play out on joyent/node. |
4 participants
Reordered the functions alphabetically, but kept the matching "Sync" functions with their async partners.
Left the classes at the end of the file, but ordered them alphabetically too.