test_runner: update kPatterns by pmarchini · Pull Request #54728 · nodejs/node

pmarchini · 2024-09-03T06:43:22Z

Fixes: #54726

nodejs-github-bot · 2024-09-03T06:43:27Z

Review requested:

@nodejs/test_runner

mcollina

lgtm

codecov · 2024-09-03T08:01:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.90%. Comparing base (26b03c1) to head (318f0d2).
Report is 163 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54728      +/-   ##
==========================================
- Coverage   87.90%   87.90%   -0.01%     
==========================================
  Files         651      651              
  Lines      183364   183364              
  Branches    35719    35718       -1     
==========================================
- Hits       161182   161180       -2     
- Misses      15461    15465       +4     
+ Partials     6721     6719       -2

Files with missing lines	Coverage Δ
lib/internal/test_runner/utils.js	`63.84% <100.00%> (ø)`

... and 22 files with indirect coverage changes

pmarchini · 2024-09-03T09:40:46Z

Hey @jakecastelli, could I please also ask for your review? 😬
Also, I think we have some issues with the CI

avivkeller · 2024-09-03T11:39:13Z

Hey @jakecastelli, could I please also ask for your review? 😬

Requesting review per the comment above

jakecastelli

Awesome work, you have also fixed the pattern for *-test 😄 looks like we don't have any coverage for *-test pattern, do you also want to add an addition test?

pmarchini · 2024-09-03T11:59:14Z

@jakecastelli, yes, no problem at all, I'm going to add it ASAP 🐍

cjihrig

LGTM. Can you change the fixture path to not be "54726"? That naming will not mean a lot in the future.

targos · 2024-09-03T12:38:56Z

Could be issue-54726

pmarchini · 2024-09-03T14:39:53Z

@jakecastelli, I added the tests for *-test.
@cjihrig, following @targos suggestion, I renamed the fixtures directory.

pmarchini · 2024-09-11T08:37:04Z

I think we are having some issues with the CI

nodejs-github-bot · 2024-09-11T09:17:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62305/

nodejs-github-bot · 2024-09-12T17:26:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62365/

nodejs-github-bot · 2024-09-12T19:51:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62374/

nodejs-github-bot · 2024-09-12T22:34:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62381/

nodejs-github-bot · 2024-09-12T23:53:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62382/ 💚

nodejs-github-bot · 2024-09-13T02:51:36Z

Landed in e21984b

PR-URL: #54728 Fixes: #54726 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

PR-URL: nodejs#54728 Fixes: nodejs#54726 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 3, 2024

pmarchini mentioned this pull request Sep 3, 2024

test_runner: latest.js file is included by default #54726

Closed

mcollina approved these changes Sep 3, 2024

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024

This comment was marked as outdated.

Sign in to view

targos approved these changes Sep 3, 2024

View reviewed changes

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 3, 2024

aduh95 approved these changes Sep 3, 2024

View reviewed changes

avivkeller requested a review from jakecastelli September 3, 2024 11:38

jakecastelli approved these changes Sep 3, 2024

View reviewed changes

cjihrig approved these changes Sep 3, 2024

View reviewed changes

lpinca approved these changes Sep 3, 2024

View reviewed changes

avivkeller added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 3, 2024

jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2024

This comment was marked as outdated.

Sign in to view

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024

This comment was marked as outdated.

Sign in to view

atlowChemi approved these changes Sep 5, 2024

View reviewed changes

pmarchini added 2 commits September 10, 2024 15:15

test: add -test.(c|m)js test cases

a052c0b

test: minor

318f0d2

pmarchini force-pushed the issue/54726 branch from 241b6bf to 318f0d2 Compare September 10, 2024 13:15

cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2024

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 10, 2024

This comment was marked as outdated.

Sign in to view

cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2024

This comment was marked as outdated.

Sign in to view

cjihrig approved these changes Sep 13, 2024

View reviewed changes

cjihrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Sep 13, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 13, 2024

nodejs-github-bot merged commit e21984b into nodejs:main Sep 13, 2024

RafaelGSS mentioned this pull request Sep 16, 2024

v22.9.0 proposal #54966

Merged

targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 22, 2024

Uh oh!

Conversation

pmarchini commented Sep 3, 2024 • edited by aduh95 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 3, 2024

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

codecov bot commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pmarchini commented Sep 3, 2024

Uh oh!

avivkeller commented Sep 3, 2024

Uh oh!

jakecastelli left a comment

Choose a reason for hiding this comment

Uh oh!

pmarchini commented Sep 3, 2024

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

targos commented Sep 3, 2024

Uh oh!

pmarchini commented Sep 3, 2024

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

pmarchini commented Sep 11, 2024

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Sep 11, 2024

Uh oh!

nodejs-github-bot commented Sep 12, 2024

Uh oh!

nodejs-github-bot commented Sep 12, 2024

Uh oh!

nodejs-github-bot commented Sep 12, 2024

Uh oh!

nodejs-github-bot commented Sep 12, 2024 • edited by jakecastelli Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

pmarchini commented Sep 3, 2024 •

edited by aduh95

Loading

codecov bot commented Sep 3, 2024 •

edited

Loading

nodejs-github-bot commented Sep 12, 2024 •

edited by jakecastelli

Loading