Skip build if with installer & no WiX install found#5220
Skip build if with installer & no WiX install found#5220dimhotepus wants to merge 1 commit intonodejs:masterfrom dimhotepus:patch-1
Conversation
If none of VS2013/VS2015 WiX installs are found on a builder machine, skip node build and notify user about.
mscdex
added
windows
|
lgtm, looks like an oversight, @dimhotepus would you mind reformatting your commit message to conform with the contributing guidelines @ https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit please? |
|
LGTM |
dimhotepus
changed the title
|
I'm quite new to Git. |
|
LGTM |
If none of VS2013/VS2015 WiX installs are found on a builder machine, skip node build and notify user about. PR-URL: #5220 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
|
No problems @dimhotepus, feel free to ask for help when you need it, we were all git newbies once and some of us feel like we are still In this case, you needed to I've landed this @ f431984, feel free to go there and have a look how I structured it. Thanks for the PR! |
If none of VS2013/VS2015 WiX installs are found on a builder machine, skip node build and notify user about. PR-URL: #5220 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
If none of VS2013/VS2015 WiX installs are found on a builder machine, skip node build and notify user about. PR-URL: nodejs#5220 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
|
@rvagg do you think this should be added to LTS? |
|
Likely safe. @nodejs/lts |
|
+1 for adding to LTS, this was an oversight and should be corrected. |
|
+1 |
If none of VS2013/VS2015 WiX installs are found on a builder machine, skip node build and notify user about. PR-URL: #5220 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
If none of VS2013/VS2015 WiX installs are found on a builder machine, skip node build and notify user about. PR-URL: #5220 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
6 participants
build: Skip node build if with installer & no WiX
When building node on windows with installer, and supported now WiX
installations are not found (VS2013 / VS2015), skip build of node and
its installer.