src: Return on UV_ENOSYS in GetInterfaceAddresses.#4703
Closed
bryce-gibson wants to merge 1 commit intonodejs:v4.xfrom
Closed
src: Return on UV_ENOSYS in GetInterfaceAddresses.#4703bryce-gibson wants to merge 1 commit intonodejs:v4.xfrom
bryce-gibson wants to merge 1 commit intonodejs:v4.xfrom
Conversation
Author
|
Ah, just found 028194b. Could it be applied to the 4.x branch? |
Contributor
|
The PR that provided that commit is #4272. It has been tagged to backport to 4.x already. |
Author
|
Oh, apologies, should've looked closer. Thanks :-) |
Contributor
|
Thanks for the contribution anyway :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using SUNOS_NO_IFADDRS (on Solaris 10, for context) libuv returns
-ENOSYS.When that error is seen this method sets the response to the error code, but continues processing.
This leads to a segfault in
uv_free_interface_addresses. Instead, just return as there is no need to process the rest of the function (afaict?)