Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
dns
Member
|
Swap "grammar" and "fix" in commit message? |
lpinca
approved these changes
Oct 1, 2022
Trott
reviewed
Oct 1, 2022
Trott
approved these changes
Oct 1, 2022
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
I know we don't always enforce it and I'm not sure we even need it, but our commit message guidelines say the first word after the subsystem should be an imperative mood verb. So, as @lpinca suggests, "fix grammar in dns docs" would be better than "grammar fix in dns docs".
If you want to get really nit-picky, I'm not sure the change here is technically a grammar fix. It's more of a style change? But now I'm getting into really low-value comments and I should stop myself.
Trott
added
the
author ready
tniessen
approved these changes
Oct 1, 2022
jasnell
approved these changes
Oct 2, 2022
RaisinTen
approved these changes
Oct 2, 2022
Trott
added
the
commit-queue-squash
Also removes some italics text, as requested in the pull request review. PR-URL: #44850 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
cjihrig
force-pushed
the
cjihrig-patch-1
branch
from
be88f02 to
46fa9e0
Compare
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
Also removes some italics text, as requested in the pull request review. PR-URL: #44850 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.