deps: V8: fix debug build#44392
Closed
bnoordhuis wants to merge 1 commit intonodejs:v18.x-stagingfrom
Closed
Conversation
This is a (very) partial cherry-pick of upstream change v8/v8@f8fddd6b13 that fixes the following debug mode build error with clang: ../deps/v8/src/codegen/register.h:29:48: error: member reference base type 'RegListBase' is not a structure or union int num_different_regs = RegListBase{regs...}.Count(); Fixes: nodejs#44371
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Member
Author
|
I'm removing the needs-ci label because I don't think CI builds V8 in debug mode anywhere. |
joyeecheung
approved these changes
Aug 25, 2022
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
I had the same patch locally before V8 was updated
gengjiawen
approved these changes
Aug 25, 2022
cjihrig
approved these changes
Aug 25, 2022
bnoordhuis
added
commit-queue
jasnell
approved these changes
Aug 28, 2022
github-actions
bot
removed
the
request-ci
Collaborator
This was referenced Aug 31, 2022
himself65
approved these changes
Sep 4, 2022
RafaelGSS
approved these changes
Sep 5, 2022
Collaborator
17 tasks
RafaelGSS
force-pushed
the
v18.x-staging
branch
from
d912d2d to
60191c6
Compare
15 tasks
RafaelGSS
force-pushed
the
v18.x-staging
branch
2 times, most recently
from
c0cfb14 to
8ef5c40
Compare
This was referenced Sep 8, 2022
Member
|
@bnoordhuis I'm about to create the next v18 proposal. But, looks like this commit isn't ready (CI red). In case you want to include it in the next v18 let me know |
RafaelGSS
force-pushed
the
v18.x-staging
branch
from
99d004e to
6dc0382
Compare
Collaborator
Contributor
|
Can we do something about blocking PRs because of faulty CI? This fix really needs to land. I'm needing to cherry-pick this commit constantly so I can test my code. |
Collaborator
19 tasks
Collaborator
danielleadams
pushed a commit
that referenced
this pull request
Oct 5, 2022
This is a (very) partial cherry-pick of upstream change v8/v8@f8fddd6b13 that fixes the following debug mode build error with clang: ../deps/v8/src/codegen/register.h:29:48: error: member reference base type 'RegListBase' is not a structure or union int num_different_regs = RegListBase{regs...}.Count(); Fixes: #44371 PR-URL: #44392 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Contributor
|
Landed in c892f35 |
This was referenced Oct 6, 2022
Merged
panva
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a (very) partial cherry-pick of upstream change v8/v8@f8fddd6b13
that fixes the following debug mode build error with clang:
Fixes: #44371