src: fix function and variable names in comments#3039
Closed
thefourtheye wants to merge 2 commits intonodejs:masterfrom
Closed
src: fix function and variable names in comments#3039thefourtheye wants to merge 2 commits intonodejs:masterfrom
thefourtheye wants to merge 2 commits intonodejs:masterfrom
Conversation
thefourtheye
added
the
c++
The `src/node.js` file is actually loaded and executed by `node::LoadEnvironment` function. The variable which has the contents is, `native_node`.
thefourtheye
force-pushed
the
fix-typos-in-comments
branch
from
a1259f7 to
952ff9c
Compare
src/node.js
Outdated
Contributor
There was a problem hiding this comment.
This should probably read "and is" instead of just "and."
Member
|
LGTM |
Contributor
Author
|
Thanks for the review @bnoordhuis :-) Landed in af881ad |
thefourtheye
added a commit
that referenced
this pull request
Sep 25, 2015
The `src/node.js` file is actually loaded and executed by `node::LoadEnvironment` function. The variable which has the contents is, `native_node`. PR-URL: #3039 Reviewed-By: Ben Noordhuis <[email protected]>
thefourtheye
added a commit
that referenced
this pull request
Sep 30, 2015
The `src/node.js` file is actually loaded and executed by `node::LoadEnvironment` function. The variable which has the contents is, `native_node`. PR-URL: #3039 Reviewed-By: Ben Noordhuis <[email protected]>
This was referenced Sep 30, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
src/node.jsfile is actually loaded and executed bynode::LoadEnvironmentfunction.The variable which has the contents is,
native_node.