Closed
Conversation
nodejs-github-bot
added
the
lib / src
lpinca
approved these changes
Feb 25, 2018
deps/node-inspect/.eslintrc
Outdated
AndreasMadsen
added
the
semver-major
addaleax
approved these changes
Feb 25, 2018
This cleans up and removes lttng support completely. Recent discussion on a PR to deprecate lttng suggested that we remove it completely pending feedback from the TSC. This should be considered a non breaking change, as a recent PR reveals that compiling with this system has been broken for nearly two years. Refs: nodejs#18971 Refs: nodejs#18975 Refs: nodejs#18945
GlenTiki
force-pushed
the
remove-lttng
branch
from
ddf3078 to
a170f7b
Compare
cjihrig
approved these changes
Feb 26, 2018
JacksonTian
approved these changes
Feb 26, 2018
evanlucas
approved these changes
Feb 26, 2018
mcollina
approved these changes
Feb 26, 2018
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
LGTM but it needs a deprecation notice
jasnell
approved these changes
Feb 26, 2018
Contributor
Author
|
I'm looking to land this today - first time that I'm landing something with a deprecation notice included. Do I amend the deprecation notice commit when landing this? |
Member
|
@thekemkid ... whomever lands the PR should assign the |
GlenTiki
added a commit
that referenced
this pull request
Mar 1, 2018
This cleans up and removes lttng support completely. Recent discussion on a PR to deprecate lttng suggested that we remove it completely pending feedback from the TSC. This should be considered a non breaking change, as a recent PR reveals that compiling with this system has been broken for nearly two years. Refs: #18971 Refs: #18975 Refs: #18945 PR-URL: #18982 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
GlenTiki
added a commit
that referenced
this pull request
Mar 1, 2018
PR-URL: #18982 Refs: #18971 Refs: #18975 Refs: #18945 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
Author
|
Landed in f7a6971...740c426 |
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This cleans up and removes lttng support completely. Recent discussion on a PR to deprecate lttng suggested that we remove it completely pending feedback from the TSC. This should be considered a non breaking change, as a recent PR reveals that compiling with this system has been broken for nearly two years. Refs: nodejs#18971 Refs: nodejs#18975 Refs: nodejs#18945 PR-URL: nodejs#18982 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18982 Refs: nodejs#18971 Refs: nodejs#18975 Refs: nodejs#18945 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jackson Tian <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up and removes lttng support completely. Recent discussion
on a PR to deprecate lttng suggested that we remove it completely
pending feedback from the TSC.
This should be considered a non breaking change, as a recent PR reveals
that compiling with this system has been broken for nearly two years.
Refs: #18971
Refs: #18975
Refs: #18945
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src, lib, lttng(?)