test: Http2Stream server stream session destroy tests in one file by trivikr · Pull Request #15624 · nodejs/node

trivikr · 2017-09-26T05:31:38Z

This PR includes all server stream session destroy tests in one file

Refs: #14985

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

test, http2

mcollina

LGTM

cjihrig · 2017-09-26T13:19:48Z

test/parallel/test-http2-server-stream-session-destroy.js

Can you name this something else since it's not actually JSON?

Done!
Renamed it to errorObj

BridgeAR · 2017-09-28T22:56:02Z

@trivikr this needs a rebase

trivikr · 2017-09-29T03:08:04Z

@BridgeAR rebase complete!

hiroppy · 2017-09-29T03:10:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/10327/

trivikr · 2017-09-29T05:49:12Z

@abouthiroppy The error in CI is the CONFLICT in 3-way merge https://ci.nodejs.org/job/node-test-commit/12680/console

This conflict is removal of first line // Flags: --expose-http2 from test files
I remember resolving this conflict while doing rebase in my private branch. The conflict is no longer shown in commits of this PR.

Refs: nodejs#14985

trivikr · 2017-09-30T08:08:46Z

@abouthiroppy Instead of merge, I performed rebase as explained in the documentation
If you trigger new CI and it's successful, it will be safe to merge this PR to master.

mcollina

LGTM

jasnell · 2017-10-01T05:35:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/10357/

trivikr · 2017-10-01T13:43:59Z

The CI failed again. As per the console output, the failure was on linux and aix.
The test command runs successfully in my workspace: ./configure && make -j4 test on macOS
The command is given in test instructions

The CI documentation states that sometimes "flaky" tests on specific platforms might fail. Is this one of those failures?

gibfahn · 2017-10-01T13:53:01Z

The test failures on AIX and Centos 32-bit x64 Linux were unrelated to this PR, CI can be considered to have passed.

gireeshpunathil · 2017-10-01T14:50:15Z

failure in AIX:

not ok 1760 sequential/test-child-process-pass-fd
  ---
  duration_ms: 1.640
  severity: fail
  stack: |-
    events.js:182
          throw er; // Unhandled 'error' event
          ^
    
    Error: spawn /home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/out/Release/node EAGAIN
        at _errnoException (util.js:1018:13)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:202:19)
        at onErrorNT (internal/child_process.js:390:16)
        at _combinedTickCallback (internal/process/next_tick.js:138:11)
        at process._tickCallback (internal/process/next_tick.js:180:9)
        at Function.Module.runMain (module.js:643:11)
        at startup (bootstrap_node.js:187:16)
        at bootstrap_node.js:605:3

While this does not hint any possibility of being related to this PR, I don't remember seeing this failure earlier, it is not listed as flaky either. @gibfahn - are you familiar with this failure, or do we have a tracker for this?

cenOS failure:

not ok 1688 inspector/test-break-when-eval
  ---
  duration_ms: 15.642
  severity: fail
  stack: |-
    [test] Connecting to a child Node process
    [test] Testing /json/list
    [err] Debugger listening on ws://127.0.0.1:60225/1304e900-59e2-4300-b971-d7f781769510
    [err] For help see https://nodejs.org/en/docs/inspector
    [err] 
    [test] Setting up a debugger
    [err] Debugger attached.
    [err] 
    [test] Breaking in the code
    [out] Ready!
    [out] 
    [test] Step over console statement and test output
    [out] 0 3
    [out] 
    Timed out waiting for matching notification (Console output matching [0,3]))
    1

No idea about this, but looks to be evidently unrelated.

gibfahn · 2017-10-01T15:32:17Z

@gireeshpunathil AIX failure is #15656

PR-URL: #15624 Refs: #14985 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

BridgeAR · 2017-10-01T23:23:31Z

Landed in 2adf680

@trivikr congraulations to your first commits to Node.js! 🎉
Just as a note - I changed the commit message because it was above 50 characters.

trivikr · 2017-10-01T23:48:05Z

Thanks @BridgeAR
I'm working with NodeJS for more than a year, and happy to finally contribute to it. Writing tests was just the beginning, identifying and fixing bugs comes next in #15676 and will hopefully be able to add features in future :-)

MylesBorins · 2017-10-03T17:50:48Z

This doesn't appear to land cleanly on v8.x. Would someone familiar with backport be willing to take a look?

PR-URL: nodejs/node#15624 Refs: nodejs/node#14985 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

MylesBorins · 2017-10-07T21:20:30Z

Quick ping re: backport

trivikr · 2017-10-07T22:25:44Z

v8.x backport PR created at #16072

PR-URL: nodejs#15624 Refs: nodejs#14985 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #15624 Refs: #14985 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 26, 2017

hiroppy added the http2 Issues or PRs related to the http2 subsystem. label Sep 26, 2017

mcollina approved these changes Sep 26, 2017

View reviewed changes

cjihrig approved these changes Sep 26, 2017

View reviewed changes

jasnell approved these changes Sep 26, 2017

View reviewed changes

trivikr force-pushed the test-http2-server-destroy branch from c3887df to a7609e2 Compare September 26, 2017 15:08

trivikr force-pushed the test-http2-server-destroy branch 3 times, most recently from a7609e2 to 48e5d2d Compare September 30, 2017 08:05

test: Http2Stream server stream session destroy tests in one file

3ffd096

Refs: nodejs#14985

trivikr force-pushed the test-http2-server-destroy branch from 48e5d2d to 3ffd096 Compare September 30, 2017 08:07

BridgeAR approved these changes Sep 30, 2017

View reviewed changes

mcollina approved these changes Sep 30, 2017

View reviewed changes

BridgeAR closed this Oct 1, 2017

trivikr deleted the test-http2-server-destroy branch October 1, 2017 23:45

MylesBorins added the backport-requested-v8.x label Oct 3, 2017

trivikr mentioned this pull request Oct 7, 2017

[v8.x backport] test: consolidate http2 tests in one file #16072

Closed

lance added backported-to-v8.x and removed backport-requested-v8.x labels Oct 28, 2017

MylesBorins added the dont-land-on-v6.x label Nov 16, 2017

Uh oh!

Conversation

trivikr commented Sep 26, 2017

Checklist

Affected core subsystem(s)

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

cjihrig Sep 26, 2017

Choose a reason for hiding this comment

Uh oh!

trivikr Sep 26, 2017

Choose a reason for hiding this comment

Uh oh!

BridgeAR commented Sep 28, 2017

Uh oh!

trivikr commented Sep 29, 2017

Uh oh!

hiroppy commented Sep 29, 2017

Uh oh!

trivikr commented Sep 29, 2017

Uh oh!

trivikr commented Sep 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell commented Oct 1, 2017

Uh oh!

trivikr commented Oct 1, 2017

Uh oh!

gibfahn commented Oct 1, 2017

Uh oh!

gireeshpunathil commented Oct 1, 2017

Uh oh!

gibfahn commented Oct 1, 2017

Uh oh!

BridgeAR commented Oct 1, 2017

Uh oh!

trivikr commented Oct 1, 2017

Uh oh!

MylesBorins commented Oct 3, 2017

Uh oh!

MylesBorins commented Oct 7, 2017

Uh oh!

trivikr commented Oct 7, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

trivikr commented Sep 30, 2017 •

edited

Loading