test: move test-http2-session-timeout#15438
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Move concurrency-sensitive test to `sequential` directory. It is failing somewhat frequently on FreeBSD in CI. Fixes: nodejs#15326
cjihrig
approved these changes
Sep 16, 2017
jasnell
approved these changes
Sep 16, 2017
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
I'm ok with fast tracking this also
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move concurrency-sensitive test to
sequentialdirectory. It is failingsomewhat frequently on FreeBSD in CI.
This is an immediate fix that can optionally be expedited. #15338 has several small improvements but does not (yet) completely remove the race condition that causes the issue. It should still land (IMO) but this is an optional fix for the problem while that PR evolves.
Fixes: #15326
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test http2