tools: simplify no-unescaped-regexp-dot rule#14561
tools: simplify no-unescaped-regexp-dot rule#14561Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
There was a problem hiding this comment.
I think the original, more descriptive variable name should be kept.
There was a problem hiding this comment.
Is it sufficiently more desirable to have a descriptive variable name that we're OK that it requires a line break in the object literal (to wrap at 80 chars due to the descriptive variable name) on line 20?
I'm OK either way. Just want to make sure the cost of the descriptive variable name is taken into account.
There was a problem hiding this comment.
You don't need to break the object format if you don't want to. You could temporarily store all or part of the loc in a separate variable to avoid that.
There was a problem hiding this comment.
OK, restored the longer name etc.
no-unescaped-regexp-dot ESLint custom rule contains feature detection that is not needed on master or the v6.x-staging branch. The rule does not exist in the v4.x-staging branch. Remove the unnecessary complexity.
|
Failures in CI are a concern but are not related to this PR. |
no-unescaped-regexp-dot ESLint custom rule contains feature detection that is not needed on master or the v6.x-staging branch. The rule does not exist in the v4.x-staging branch. Remove the unnecessary complexity. PR-URL: #14561 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in a92a5c1 |
no-unescaped-regexp-dot ESLint custom rule contains feature detection that is not needed on master or the v6.x-staging branch. The rule does not exist in the v4.x-staging branch. Remove the unnecessary complexity. PR-URL: #14561 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
no-unescaped-regexp-dot rule doesn't exist on LTS right now. |
@MylesBorins It was added in #11834 which has not yet been backported. |
6 participants
no-unescaped-regexp-dot ESLint custom rule contains feature detection
that is not needed on master or the v6.x-staging branch. The rule does
not exist in the v4.x-staging branch. Remove the unnecessary complexity.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools