Conversation
Contributor
|
Question, should this be split across 2 lines with I'd say LGTM since the linter will complain otherwise. |
Contributor
Author
I'd rather not do that, as it could seem intrusive. There's an argument for 80 characters, but it'd be our first muli-line print. I've found two more cases with long messages: https://github.com/iojs/io.js/blob/cd60ff03281a7e5a2cf0f7a2349303f1d44bb778/lib/buffer.js#L446-L447 |
silverwind
added a commit
that referenced
this pull request
Apr 17, 2015
This makes the linter happy again. PR-URL: #1453 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Contributor
Author
|
Merged in 5b844e1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style fix for #1363
R=@Fishrock123