CRYPTO: Add configure option to use system CA certificates#11774
Closed
sgallagher wants to merge 1 commit intonodejs:masterfrom
Closed
CRYPTO: Add configure option to use system CA certificates#11774sgallagher wants to merge 1 commit intonodejs:masterfrom
sgallagher wants to merge 1 commit intonodejs:masterfrom
Conversation
This patch allows distribution packagers to pass a `--system-ca-certificates` argument to `./configure` in order to specify a CA certificate bundle file on the system on which Node will be installed. If this argument is passed, Node will *only* use the system CA certificates and not its internal built-in ones, though they can still be extended through the use of the NODE_EXTRA_CA_CERTS environment variable. Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
nodejs-github-bot
added
build
Contributor
Author
|
This should be a proper solution for #4175 |
Contributor
Author
|
Hmm, I just saw that something landed in Node.js 7.5.0 that is similar... |
2 tasks
This was referenced Mar 7, 2020
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 1, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows distribution packagers to pass a
--system-ca-certificatesargument to./configurein order tospecify a CA certificate bundle file on the system on which Node
will be installed. If this argument is passed, Node will only
use the system CA certificates and not its internal built-in ones,
though they can still be extended through the use of the
NODE_EXTRA_CA_CERTS environment variable.
Signed-off-by: Stephen Gallagher sgallagh@redhat.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
crypto