benchmark: fix timer display in progress output

[mscdex]

This commit fixes an issue where the minutes would not display properly on the benchmark timer once an hour had elapsed.

/cc @AndreasMadsen @joyeecheung

Lint: https://ci.nodejs.org/job/node-test-linter/6921/

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

• benchmark

[AndreasMadsen]

What is the reason for the other changes, only minutes was calculated wrong?

[mscdex]

@AndreasMadsen True, only minutes were calculated wrong, but because of that, seconds need to be re-calculated as well. Additionally, I could have used a temporary variable to make the adjustment once and base the minutes and seconds off of that, but I opted to just duplicate the calculations inline.

[AndreasMadsen]

I think it is fine, but I'm pretty sure that x mod m^2 mod m = x mod m, so the seconds shouldn't have changed unless something javascript-mysterious is going on.

[joyeecheung]

Hmm, sorry about not testing this earlier (come to think of it I could've just change the clock and observe), thanks for fixing this.

I think (time % 3600) % 60 is the same as time % 60 like @AndreasMadsen suggests above, but I think the former works fine too.

[jasnell]

I thought that had looked off but hadn't taken the time yet to investigate. Thanks for this

[jasnell]

landed in a08fcc0

[jasnell]

Depends on previous landed PR that has not been backported to v6 or v4. Marking as don't land on those branches.