Skip to content

doc: Fix Math Error#11158

Closed
DiegoRBaquero wants to merge 1 commit intonodejs:masterfrom
DiegoRBaquero:patch-2
Closed

doc: Fix Math Error#11158
DiegoRBaquero wants to merge 1 commit intonodejs:masterfrom
DiegoRBaquero:patch-2

Conversation

@DiegoRBaquero
Copy link
Contributor

@DiegoRBaquero DiegoRBaquero commented Feb 4, 2017

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@DiegoRBaquero
Fix Math Error
b477bb7 
Updates benchmark result output to actual real result.

1 * 1e9 + 552 = 1000000552 not 1000000527
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Feb 4, 2017
@addaleax
Copy link
Member

addaleax commented Feb 4, 2017

Could you modify the subject line of your commit message so that it reads “doc: fix math error” (all lowercase)? git commit --amend && git push --force-with-lease should get you there. :) If you prefer, that can also be done by the person who merges your PR.

@DiegoRBaquero
Copy link
Contributor Author

DiegoRBaquero commented Feb 4, 2017

I did it through GitHub, finding it hard time to fix it with CLI. Whoever merges it please do it.

@addaleax
Copy link
Member

addaleax commented Feb 4, 2017

This doesn’t need to wait 48 hours.

Landed in c5a0dce, thank you for the PR!

@addaleax addaleax closed this Feb 4, 2017
addaleax pushed a commit that referenced this pull request Feb 4, 2017
@DiegoRBaquero @addaleax
doc: fix math error in process.md
c5a0dce 
Updates benchmark result output to actual real result.

1 * 1e9 + 552 = 1000000552 not 1000000527

PR-URL: #11158
Reviewed-By: Anna Henningsen <[email protected]>
@DiegoRBaquero DiegoRBaquero deleted the patch-2 branch February 4, 2017 05:56
@italoacasas
Copy link

italoacasas commented Feb 5, 2017

This depends on a semver-major, adding labels.

@DiegoRBaquero
Copy link
Contributor Author

DiegoRBaquero commented Feb 5, 2017

@italoacasas Why is that? The fix should apply to all versions with the wrong doc.

@italoacasas
Copy link

italoacasas commented Feb 5, 2017

In the git history, the commit before in the file is a semver-major, because of that we cannot land this commit in v7.x for example, since we don't have the previous commit, we need to backport. I was planning to do it, but if you want is going to be helpful.

krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
@DiegoRBaquero @krydos
doc: fix math error in process.md
c17ff1d 
Updates benchmark result output to actual real result.

1 * 1e9 + 552 = 1000000552 not 1000000527

PR-URL: nodejs#11158
Reviewed-By: Anna Henningsen <[email protected]>
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DiegoRBaquero @addaleax @italoacasas @nodejs-github-bot