Skip to content

Conversation

@kraenhansen
Copy link
Contributor

Using this package in an NPM project, poisons the PATH making when running clang-format from a package script. Since clang-format here is only used when developing and on CI, there's no reason to declare it as a non-dev dependency.

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you use this package in another repo though?

@legendecas legendecas merged commit 4b7dd86 into nodejs:main Feb 2, 2026
17 checks passed
@github-project-automation github-project-automation bot moved this from Has PR to Done in Node-API Team Project Feb 2, 2026
@kraenhansen
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants