test: move core saving and loading into common.js#167
Merged
joyeecheung merged 3 commits intonodejs:masterfrom Feb 14, 2018
Merged
test: move core saving and loading into common.js#167joyeecheung merged 3 commits intonodejs:masterfrom
joyeecheung merged 3 commits intonodejs:masterfrom
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
Author
|
@cjihrig Thanks for the review. Updated, PTAL. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
Author
|
@bnoordhuis I think |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was used by #147 to reuse the code that generates a core dump and saves it for testing, but it's worth getting merged first.
cc @cjihrig @bnoordhuis