Skip to content

support nodejs 18 and enable next loader in the chain to continue resolution#5

Merged
internettrans merged 2 commits into
node-loader:masterfrom
giltayar:master
Jul 18, 2022
Merged

support nodejs 18 and enable next loader in the chain to continue resolution#5
internettrans merged 2 commits into
node-loader:masterfrom
giltayar:master

Conversation

@giltayar
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Collaborator

@internettrans internettrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Copy Markdown
Collaborator

@internettrans internettrans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package.json change broke this. I will undo it.

Comment thread package.json Outdated
@internettrans internettrans merged commit e8cf0ea into node-loader:master Jul 18, 2022
@internettrans
Copy link
Copy Markdown
Collaborator

@raihle
Copy link
Copy Markdown

raihle commented Aug 19, 2022

FYI (and perhaps for future searchers), this fix broke our (admittedly broken) config where @node-loader/http was before @node-loader/import-maps in the chain. Reversing the order fixed the problem.

Example error message:

Error [ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only file and data URLs are supported by the default ESM loader. Received protocol 'https:'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants