fix(mawaqit): update to v1.3.7 from v1.0.0, applying latest changes - #425
fix(mawaqit): update to v1.3.7 from v1.0.0, applying latest changes#425mugaizzo wants to merge 1 commit into
Conversation
|
CC @ycf-anon |
|
@mugaizzo hey,I didn’t include the azan MP3s because I don’t have the licenses for them |
|
@ycf-anon I checked the metadata of the mp3 via:
and the Artist is And indeed the Aazns are hosted in: https://islamcan.com/audio/adhan/index.shtml The title of that url mentions "free download", we can just put attribute to the url in the read me or something. Other websites are also refering to islamcan website, check: https://islamfactory.com/audio/adhan |
|
@ycf-anon Btw, the same Azan are in Internet Archive: https://archive.org/download/AdhaN_Divers_up-by-muslem , named:
|
|
will be waiting for final approval |
|
@ycf-anon let me know what to do with this, or I'll close it, thanks |
|
Calendar tab looks good. For the MP3s, we don't have a valid license for them, so @mugaizzo please drop them from this PR until we find properly licensed audio. "Free download" is not a license, Also, with a feature this big (calendar tab), this should bump to v2.0.0, not v1.3.7 |
Applied the latest changes done on V4. Skipped previous translation from V4, I'm not familier with those languages, I used the same azan[1,2,3].mp3 files from https://islamcan.com/audio/adhan/index.shtml.
Plugin
ycf/mawaqitplugin.toml)What it does
External dependencies
Testing
Screenshots / Videos
Checklist
Ready-for-review requirement: Every box in this section must be checked. If any statement is not true, keep the
pull request as Draft. An explanation does not replace a required check.
idafter the/inplugin.tomlexactly.plugin.toml,README.md,thumbnail.webp, andtranslations/en.json.README.mdfollows theREADME template, documents
every entry id and dependency, and includes exact panel IPC commands and launcher prefixes where applicable.
thumbnail.webpwith the thumbnail generator.versionfollows semver and is bumped in this PR;plugin_apiis the oldest API level this plugin requires.understand that language well enough to review and maintain it (no unreviewed machine/LLM translations).
catalog.toml; CI generates it.Code review attestation
Plugins run as trusted, unsandboxed Luau in the user's session. Confirm:
Ready-for-review requirement: Every attestation below must be checked.
licensedeclared inplugin.toml.