Skip to content

Improve subclass creation#13

Merged
nocarryr merged 10 commits intomasterfrom
subclass-creation
Apr 23, 2022
Merged

Improve subclass creation#13
nocarryr merged 10 commits intomasterfrom
subclass-creation

Conversation

@nocarryr
Copy link
Copy Markdown
Owner

@nocarryr nocarryr commented Apr 4, 2022

Use __init_subclass__ instead of __new__. Removes the need to iterate through all base classes while looking for event and property definitions.

  • This PR will not maintain compatibility with Python < 3.6, so the appropriate project metadata should be added for setuptools/PyPI.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 4, 2022

Coverage Status

Coverage increased (+0.9%) to 97.312% when pulling 49fcda6 on subclass-creation into 4a03bf3 on master.

@nocarryr nocarryr merged commit 51fc90f into master Apr 23, 2022
@nocarryr nocarryr deleted the subclass-creation branch April 23, 2022 20:05
nocarryr added a commit that referenced this pull request Apr 27, 2022
No longer necessary after changes in #13

Fixes #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants