Merged
Conversation
as a OBI:manufacturer that has a manufaturer role which is realized in a manufacturing process that has as specified output some part of an "NMR instrument". Which includes whole NMR instruments due to part of being transitive.
…vice manufacturer'
…t it is a part of an 'NMR instrument'
…device and add cardinal part of an NMR instrument axiom to each
…x to be in line with the other classes and add 'part of' some 'NMR instrument' axiom
add 'NMR' as label prefix to be in line with the other classes and add "'part of' some 'NMR instrument'" axiom
and add equivalentTo axiom to allow the inference of its children
to be in line with the labeling of the other NMR devices
add an equivalentTo axiom that contains the union of all NMR devices considered an optional part of a NMR instrument, so that these can be iferred children of this class.
…d 'instrument' to the label
…trument' to the label
and add 'instrument' to its descendants
…devices to their manufactureres
to link them to #12 for provenance
Contributor
Author
|
@NRayya I'd be ready with this imo |
NRayya
deleted the
12_rework_NMR_instruments_and_manufacutrers_eqivalence_approach
branch
Merged
StroemPhi
added a commit
that referenced
this pull request
Mar 21, 2025
This PR makes a new release for nmrCV to reflect the current changes made by NFDI4Chem. Changes summary: * **ATTENTION: This might introduce breaking changes with regard to using nmrCV in conjunction with nmrML! We therefore advise to keep using nmrCV version 1.1.0 with nmrML!** * The maintenance & development of nmrCV was migrated to an [Ontology Development Kit based workflow](https://github.com/INCATools/ontology-development-kit/tree/master), see also: #1, #8, #14 & #30. Due to that nmrCV: * is now also published in the form of `full` and `base` [release artefacts](https://oboacademy.github.io/obook/reference/release-artefacts/) in .obo, .ttl as well as .owl serialization. * now imports terms from exisiting ontologies, such as CHEBI, BFO, RO, OBI & IAO, instead of redefining them anew, * most importantly it imports chemical entites from CHEBI as was initially planned and its nmrCV placeholder terms where thus properly deprecated, see also #13, #18, #26, #29. #53, #54 & #55, * is now using a date based versioning scheme instead of a [semantic versioning scheme](https://semver.org/), starting with the 2025-03-19 release, which can be interpreted as a 2.0_alpha version. * In the present PR the ontology annotations where updated to include the new NFDI4Chem contributors and to reflect the reviving of nmrCV and its new scope. * Annotations specific to the contributors of the previous version where adjusted, in that contributors are now consistently listed individually using `dc:contributor` where no ORCID could be identified and `dcterms.contributor` where corresponding ORCIDs could be identified. * The textual definition of `NMR sample` was made more general in #2. * The NMR manufacturer pattern was harmonized with OBI in #40 * The calibration compound branch was improved in #45. * The class `characterized compound` was added in #37 A complete list of changes was created with `robot diff`: * [diff_nmrCV1.1-nmrCV2.0alpha.md](https://github.com/nmrML/nmrCV/blob/main/diff_nmrCV1.1-nmrCV_2025-03-20.md) * [diff_nmrCV1.1-nmrCV2.0alpha.html](https://github.com/nmrML/nmrCV/blob/main/diff_nmrCV1.1-nmrCV_2025-03-20.html)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12