Export Formatter, Unit and Suffix types#231
Merged
Merged
Conversation
Signed-off-by: Andres Morey <andresmarcel@gmail.com>
Philipp91
added a commit
to Philipp91/react-timeago
that referenced
this pull request
May 9, 2026
Fixes nmn#234. nmn#231 had turned the `import type` line into an `export type` line to re-export the types, but missed that [re-exported types "do not become available inside the current module"](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/export#re-exporting_aggregating), yet the `Formatter` type is actually used within the same file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #230
This PR exports
Formatter,UnitandSuffixtypes which were present in v7. Now you can do this again: