Repository navigation
Split the Visual Studio 2019 AppVeyor job into two shards - #5872
Merged
Merged
Conversation
The Visual Studio 2019 job (Release, x86, JSON_ImplicitConversions=OFF) builds the tests for all standards and takes 49 to 57 minutes when it passes, close to AppVeyor's 60-minute limit per job. In build 54917118 (#5867), build 54917312 (#5620), and build 54930878 (#5851) it was stopped at the limit while still compiling. Split it with JSON_TestShard like the Visual Studio 2017 jobs. Signed-off-by: Niels Lohmann <mail@nlohmann.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AppVeyor job for Visual Studio 2019 (Release, x86,
-DJSON_ImplicitConversions=OFF) builds the unit tests for all C++ standards. When it passes, it takes 49 to 57 minutes, which is close to AppVeyor's 60-minute limit per job. In three recent builds it was stopped at that limit while still compiling ("Build execution time has reached the maximum allowed time for your plan (60 minutes)"):None of those PRs touched anything that job uses.
This PR splits the job into two shards with
JSON_TestShard=0/2and1/2, as the Visual Studio 2017 jobs already do. AppVeyor builds PRs from the merge commit withdevelop, so once this is merged, every open PR gets the split without a rebase.Breaking changes
No breaking changes. Only the AppVeyor CI configuration changes.
Written by Claude Code on behalf of @nlohmann.
🤖 Generated with Claude Code