Skip to content

Simplify module API - #4836

Closed
mikomikotaishi wants to merge 44 commits into
nlohmann:developfrom
mikomikotaishi:develop
Closed

Simplify module API#4836
mikomikotaishi wants to merge 44 commits into
nlohmann:developfrom
mikomikotaishi:develop

Conversation

@mikomikotaishi

@mikomikotaishi mikomikotaishi commented Jun 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • The changes are described in detail, both the what and why.
  • If applicable, an existing issue is referenced.
  • The Code coverage remained at 100%. A test case for every new line of code.
  • If applicable, the documentation is updated.
  • The source code is amalgamated by running make amalgamate.

This pull request follows up with and addresses a previous pull request, #4799. Here we reduce the using statements to non-templated using statements as it is simpler and does not interfere with the original header API.

@mikomikotaishi
mikomikotaishi requested a review from nlohmann as a code owner June 30, 2025 00:34
nlohmann and others added 20 commits June 29, 2025 20:36
@nlohmann @mikomikotaishi
Update customers and add Cloudback (#4797)
2842a3a 
* 📝 update customers

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

* 📝 add badge to Cloudback

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

---------

Signed-off-by: Niels Lohmann <mail@nlohmann.me>
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Add proper C++20 module support
6036609 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Should be OFF by default
3ded69d 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Missing template parameters
8ffa701 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Change acknowledgement description in README
ee2b417 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Should be OFF again
bf2ff16 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Should have D in front of it
a027a27 
Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com>
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Remove acknowledgement
3bd7d0b 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Revert aliasing changes
69ac4d1 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Forgot to revert this one
1c0201a 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Attempt to fix ci_module_cpp20 test
a324ce4 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Attempt 2 at fix ci_module_cpp20 test
2f1c908 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
This should fix the problems with testing modules
18a207b 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Wrote build files to wrong target
8fa4eae 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
This should be the fix, the module test works
1c4c535 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Make changes as requested
8b857e4 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@nlohmann @mikomikotaishi
Adjust warnings flags (#4801)
964de69 
* 🚨 suppress warnings

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

* 🚨 suppress warnings

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

* 🚨 suppress warnings

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

* 🚨 suppress warnings

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

* 🚨 suppress warnings

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

* 🚨 suppress warnings

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

---------

Signed-off-by: Niels Lohmann <mail@nlohmann.me>
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi @nlohmann
Update cmake/ci.cmake
92d0699 
Co-authored-by: Niels Lohmann <niels.lohmann@gmail.com>
Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com>
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Requested changes
d0898d5 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Requested changes
bead746 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
dependabot Bot and others added 4 commits June 29, 2025 20:36
@dependabot @mikomikotaishi
⬆️ Bump lukka/get-cmake from 4.0.2 to 4.0.3 (#4820)
728cc78 
Bumps [lukka/get-cmake](https://github.com/lukka/get-cmake) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/lukka/get-cmake/releases)
- [Commits](lukka/get-cmake@ea00481...6b3e96a)

---
updated-dependencies:
- dependency-name: lukka/get-cmake
  dependency-version: 4.0.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@ddkilzer David Kilzer @mikomikotaishi
🐛 add missing header to input_adapters.hpp (#4830)
33eee5a 
Signed-off-by: David Kilzer <ddkilzer@apple.com>
Co-authored-by: David Kilzer <ddkilzer@apple.com>
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Simpler using statement for cleaner module API
b590847 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Merge branch 'develop' into develop
0834e67 
Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com>
@github-actions github-actions Bot added L and removed M labels Jun 30, 2025
@mikomikotaishi
Missing newline in list
e421af4 
Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com>
@coveralls

coveralls commented Jun 30, 2025 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

coverage: 99.19%. remained the same
when pulling 2afacab on mikomikotaishi:develop
into d33ecd3 on nlohmann:develop.

@nlohmann

nlohmann commented Jul 1, 2025

Copy link
Copy Markdown
Owner

Can you please rebase to the latest develop to have a cleaner git history?

mikomikotaishi and others added 12 commits July 1, 2025 12:17
@mikomikotaishi
Merge branch 'nlohmann:develop' into develop
2afacab
@mikomikotaishi
Add proper C++20 module support
a27148f 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Revert aliasing changes
f585024 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Attempt to fix ci_module_cpp20 test
6523eef 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Attempt 2 at fix ci_module_cpp20 test
ed664ee 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
This should fix the problems with testing modules
6920e07 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Wrote build files to wrong target
892c21c 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
This should be the fix, the module test works
bb9f397 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Make changes as requested
9e95ec2 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@mikomikotaishi
Requested changes
ce9e815 
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@nlohmann @mikomikotaishi
Encode infinity and NaN as float for MsgPack and CBOR (#4802)
6ea1762 
* 🚸 encode infinity and NaN as float for MsgPack and CBOR

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

* 🚨 suppress warnings

Signed-off-by: Niels Lohmann <mail@nlohmann.me>

---------

Signed-off-by: Niels Lohmann <mail@nlohmann.me>
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@dependabot @mikomikotaishi
⬆️ Bump step-security/harden-runner from 2.12.0 to 2.12.1 (#4815)
3da5741 
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.12.0 to 2.12.1.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](step-security/harden-runner@0634a26...002fdce)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-version: 2.12.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Toyosatomimi no Miko <110693261+mikomikotaishi@users.noreply.github.com>
@github-actions github-actions Bot added L CI tests and removed M labels Jul 1, 2025
@mikomikotaishi

mikomikotaishi commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

Whatever I did didn't seem to fix it, I'll just make a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlohmann nlohmann Awaiting requested review from nlohmann nlohmann is a code owner

Assignees

No one assigned

Labels

CI documentation L tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikomikotaishi @coveralls @nlohmann @ddkilzer